Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs dependency and tooling updates as a maintenance/chore task. It updates ruff (0.14.14 → 0.15.1), prek (0.2.29 → 0.3.2), and bandit (1.9.2 → 1.9.3), adds a new pre-commit hook (typos spell checker), reorganizes ruff.toml linter configuration alphabetically, and refactors code in mddb.py to use a named constant.
Changes:
- Updated development dependencies (ruff, prek, bandit) to newer versions
- Added typos pre-commit hook for spell checking
- Reorganized and expanded ruff linting rules in ruff.toml
- Refactored hard-coded value to named constant in mddb.py
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updated dependency lock file with new versions of ruff, prek, bandit, and other transitive dependencies |
| pyproject.toml | Bumped minimum versions for dev dependencies (bandit, prek, ruff) |
| .pre-commit-config.yaml | Updated ruff hook version and added typos spell checker hook |
| ruff.toml | Reorganized lint rules alphabetically, added new rules (e.g., PL, FURB, LOG), and added PLR to ignore list |
| src/mdverse_scrapers/scrapers/mddb.py | Extracted magic number 100 to named constant MAX_NUMBER_OF_DATASETS_IN_DEBUG |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "NPY", # NumPy-specific rules - ensures NumPy coding standards | ||
| "PD", # Pandas-vet - checks pandas-specific code practices | ||
| "PERF", # Perflint - performance-related checks | ||
| "PL", # Pylint rules |
There was a problem hiding this comment.
The configuration enables "PL" (Pylint rules) on line 33 but then ignores "PLR" (Pylint recommendations) on line 45. This is contradictory because "PLR" is a subset of "PL". Either remove "PL" from the extended select list, or remove "PLR" from the ignore list to maintain consistency.
1 participant
No description provided.